• Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Register
  • Login
Bagisto Forum

Bagisto

  • Register
  • Login
  • Search
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups

There are duplicate image files in the source code

Knowledge Base
3
6
460
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • K
    khanhlp last edited by khanhlp 27 Oct 2020, 07:38 27 Oct 2020, 07:24

    Hi guys, Could I ask you a question?

    I have checked in the source code, there are duplicate files (uppercase and lowercase).
    2.PNG
    1.PNG
    What is the purpose of this?

    Thanks!

    1 Reply Last reply Reply Quote 0
    • V
      Vaishali Agarwal last edited by 27 Oct 2020, 07:45

      @khanhlp
      could you mention the file path?

      K 1 Reply Last reply 27 Oct 2020, 07:54 Reply Quote 0
      • K
        khanhlp @Vaishali Agarwal last edited by 27 Oct 2020, 07:54

        @Vaishali-Agarwal
        this is path:
        /packages/Webkul/Ui/src/Resources/assets/sass/icons.scss
        /packages/Webkul/Shop/src/Resources/assets/sass/icons.scss

        1 Reply Last reply Reply Quote 0
        • V
          vishalK last edited by 27 Oct 2020, 13:22

          Hi @khanhlp

          We did not find any duplicate images in your mentioned files you can verify this with our github code :

          https://github.com/bagisto/bagisto/blob/master/packages/Webkul/Ui/src/Resources/assets/sass/icons.scss

          https://github.com/bagisto/bagisto/blob/master/packages/Webkul/Shop/src/Resources/assets/sass/icons.scss

          Please correct me if i did not get your point.
          Thanks!

          K 1 Reply Last reply 27 Oct 2020, 15:29 Reply Quote 0
          • K
            khanhlp @vishalK last edited by 27 Oct 2020, 15:29

            Hi @vishalK
            Thanks for the reply.
            I mean the two files image Arrow-Down.svg and arrow-down.svg are the same, the only difference in the name is uppercase and lowercase. Why don't we use only a file, arrow-down.svg, instead of using both Arrow-Down.svg and arrow-down.svg files.
            image (1).jpg
            image.jpg
            so when I pull the code, I will get the warning:

            eece3c60-5e03-4218-833d-400d63e1b50e-image.png

            1 Reply Last reply Reply Quote 0
            • V
              Vaishali Agarwal last edited by Vaishali Agarwal 27 Oct 2020, 16:20 27 Oct 2020, 16:18

              @khanhlp
              both icons are different https://prnt.sc/v81phx , if you look into this icons at location
              themes/default/assets/images/Arrow-Down.svg
              themes/default/assets/images/arrow-down.svg

              1 Reply Last reply Reply Quote 0
              1 out of 6
              • First post
                1/6
                Last post