loader at checkout form

Rahul74 · 25 Jul 2020, 06:03

@Vaishali-Agarwal one more thing i couldn't able to do is in the checkout form, the last name is required, i want to remove the last name, can u help how to do it?

Vaishali Agarwal · 25 Jul 2020, 07:01

@Rahul74
removing the last name will take a lot of code to be change, instead of this you can also set Last_Name field to be non-required fields, so if user can proceed with adding the lastname

Rahul74 · 25 Jul 2020, 10:01

@Vaishali-Agarwal Hi can u tell me what thise rich snippets are for ?

Vaishali Agarwal · 25 Jul 2020, 10:54

@Rahul74
Rich snippets help Google search engines better comprehend its context for search results display. When you enable the Rich Snippets for products then this employed, search engines are able to display more information about the actual result, including your products ratings, reviews, price etc and increase your website page rank.

Thanks

otheriz · 26 Jul 2020, 11:34

@Vaishali-Agarwal i just pulled from the master branch, but don't have any of this 'loading' effect
currently, i using my custom theme but just copied velocity theme with little design change..

is there's anything i need to do/copied(which file?) after pulling the latest from the master branch ?

Edit:
I just realise this error on console log "Uncaught (in promise) TypeError: this.$root.showLoader is not a function
at onepage:2890"
What to do ?

Vaishali Agarwal · 27 Jul 2020, 09:20

@otheriz
can i access your website url where you have done all these changes?

Rahul74 · 27 Jul 2020, 11:11

@Vaishali-Agarwal Is this the correct solution?? i have removed those two lines of codes indicated with arrow. For loader occuring even entering single digit..

Vaishali Agarwal · 27 Jul 2020, 11:17

Hi @Rahul74
No this is not the solution, as provided in the screenshot, the solution is mention in the PR which is signed with merged now as https://prnt.sc/tp89he
The PR is here https://github.com/bagisto/bagisto/pull/3576/files

Rahul74 · 27 Jul 2020, 11:38

@Vaishali-Agarwal i did this change but its not seemed to fix that,

Vaishali Agarwal · 27 Jul 2020, 11:41

Hope you have run these commands
composer dump-autoload
php artisan config:cache
php artisan vendor:publish --force

Rahul74 · 27 Jul 2020, 11:53

@Vaishali-Agarwal it's same.

Rahul74 · 27 Jul 2020, 11:56

@Vaishali-Agarwal we don't need to remove any of that?

Vaishali Agarwal · 27 Jul 2020, 12:05

@Rahul74
No, no need to remove this.$root.showLoader();
I also changed my code which is already merged in the master and it's working fine

Rahul74 · 27 Jul 2020, 13:50

@Vaishali-Agarwal ok

Vaishali Agarwal · 27 Jul 2020, 13:51

@Rahul74
now working??

Rahul74 · 27 Jul 2020, 14:04

@Vaishali-Agarwal no, still not working, i have tried in incognito too,

devansh-webkul · 27 Jul 2020, 14:19

Hi @Rahul74,

May I know the exact file name and path in which you are changing. Can you please share the screenshot of the checkout page in which you have entered all fields so that I can see the case.

Rahul74 · 27 Jul 2020, 16:22

@devansh419

devansh-webkul · 28 Jul 2020, 04:15

@Rahul74,

So, in the first image changes made in the path of the package so you need to run the command so that these changes will reflect the theme as well.

php artisan vendor:publish --all --force

If this doesn't work then try to remove a file from this path i.e.,
'resources/themes/velocity/views/checkout/onepage/customer-new-form.blade.php'

and again run the same command i.e.

php artisan vendor:publish --all --force

Rahul74 · 28 Jul 2020, 07:27

@devansh419 if i remove that file, it shows 500 error